Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor javascript files and the popup #199

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Nov 2, 2024

Decided to refactor some little things 🤕

Now the popup is this way. Hope you agree to the changes!

Screenshot 2024-11-02 at 17 04 12

What do you think to change the texts to?

  • Barra de navegação
  • Esconder atalhos
  • Nova fonte de letra
  • Relembrar sessão

@thePeras thePeras force-pushed the refactor/ts-and-popup branch from aedf41d to 4c6a667 Compare November 2, 2024 19:06
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very good 🤩, we could start migrating some of these things to tsx. also what do you think about separating options further by page? it could be helpful as we increase customisation.

@thePeras
Copy link
Member Author

thePeras commented Nov 7, 2024

What do you think about separating options further by page? it could be helpful as we increase customisation.

I agree. I put a comment in the file, so when the options increase next time, could be an improvement

@thePeras thePeras merged commit 84f4d1e into develop Nov 7, 2024
2 checks passed
@thePeras thePeras deleted the refactor/ts-and-popup branch November 7, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants